-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
03-Implemented changes for custom python test #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquidute
requested review from
fabiowmm,
ccruzagralopes,
antonio-amjr and
hiltonlima
November 12, 2024 23:24
hiltonlima
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check the CI errors
spelling and unit test are still failing. At first, it does not make sense to me. I will merge this PR now and check this afterwards. In case, I will open a new PR to fix this CI issues. |
ccruzagralopes
approved these changes
Nov 14, 2024
test_collections/matter/sdk_tests/support/python_testing/sdk_python_tests.py
Outdated
Show resolved
Hide resolved
test_collections/matter/sdk_tests/support/python_testing/sdk_python_tests.py
Outdated
Show resolved
Hide resolved
antonio-amjr
approved these changes
Nov 14, 2024
ccruzagralopes
approved these changes
Nov 14, 2024
rquidute
changed the title
Implemented changes for custom python test
03-Implemented changes for custom python test
Nov 18, 2024
hiltonlima
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Implemented changes for custom python test * code review * Code review * Code reviewd * Fixed code violations * Chanegs after code review * Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Updated the files related to custom python tests in order to the be in accordance with the changes with the way to retrieve test steps names.
Related Issue
project-chip/certification-tool#484
Testing
Unit test updated and passing
TH UI List the custom test case
TH UI execution runs successfully the Custom Python test case.